Eduardo Valentin e5e5c0ec39 bridge: mdb: fix leak on complete_info ptr on fail path ... commit 1bfb159673957644951ab0a8d2aec44b93ddb1ae upstream. We currently get the following kmemleak report: unreferenced object 0xffff8800039d9820 (size 32): comm "softirq", pid 0, jiffies 4295212383 (age 792.416s) hex dump (first 32 bytes): 00 0c e0 03 00 88 ff ff ff 02 00 00 00 00 00 00 ................ 00 00 00 01 ff 11 00 02 86 dd 00 00 ff ff ff ff ................ backtrace: [<ffffffff8152b4aa>] kmemleak_alloc+0x4a/0xa0 [<ffffffff811d8ec8>] kmem_cache_alloc_trace+0xb8/0x1c0 [<ffffffffa0389683>] __br_mdb_notify+0x2a3/0x300 [bridge] [<ffffffffa038a0ce>] br_mdb_notify+0x6e/0x70 [bridge] [<ffffffffa0386479>] br_multicast_add_group+0x109/0x150 [bridge] [<ffffffffa0386518>] br_ip6_multicast_add_group+0x58/0x60 [bridge] [<ffffffffa0387fb5>] br_multicast_rcv+0x1d5/0xdb0 [bridge] [<ffffffffa037d7cf>] br_handle_frame_finish+0xcf/0x510 [bridge] [<ffffffffa03a236b>] br_nf_hook_thresh.part.27+0xb/0x10 [br_netfilter] [<ffffffffa03a3738>] br_nf_hook_thresh+0x48/0xb0 [br_netfilter] [<ffffffffa03a3fb9>] br_nf_pre_routing_finish_ipv6+0x109/0x1d0 [br_netfilter] [<ffffffffa03a4400>] br_nf_pre_routing_ipv6+0xd0/0x14c [br_netfilter] [<ffffffffa03a3c27>] br_nf_pre_routing+0x197/0x3d0 [br_netfilter] [<ffffffff814a2952>] nf_iterate+0x52/0x60 [<ffffffff814a29bc>] nf_hook_slow+0x5c/0xb0 [<ffffffffa037ddf4>] br_handle_frame+0x1a4/0x2c0 [bridge] This happens when switchdev_port_obj_add() fails. This patch frees complete_info object in the fail path. Reviewed-by: Vallish Vaidyeshwara <vallish@amazon.com> Signed-off-by: Eduardo Valentin <eduval@amazon.com> Signed-off-by: David S. Miller <davem@davemloft.net> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>		2017-07-21 07:42:17 +02:00
..
netfilter	Merge branch 'master' of git://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next	2016-09-25 23:34:19 +02:00
Kconfig	…
Makefile	bridge: switchdev: Add forward mark support for stacked devices	2016-08-26 13:13:36 -07:00
br.c	netfilter: bridge: clarify bridge/netfilter message	2016-10-02 22:44:03 -04:00
br_device.c	net: bridge: change unicast boolean to exact pkt_type	2016-09-01 22:48:33 -07:00
br_fdb.c	rtnetlink: fdb dump: optimize by saving last interface markers	2016-09-01 16:56:15 -07:00
br_forward.c	net: bridge: allow IPv6 when multicast flood is disabled	2017-03-22 12:43:32 +01:00
br_if.c	net: bridge: add per-port multicast flood flag	2016-09-01 22:48:33 -07:00
br_input.c	bridge: drop netfilter fake rtable unconditionally	2017-03-22 12:43:34 +01:00
br_ioctl.c	Merge git://git.kernel.org/pub/scm/linux/kernel/git/davem/net	2016-05-09 15:59:24 -04:00
br_mdb.c	bridge: mdb: fix leak on complete_info ptr on fail path	2017-07-21 07:42:17 +02:00
br_multicast.c	bridge: multicast: restore perm router ports on multicast enable	2016-10-18 13:52:13 -04:00
br_netfilter_hooks.c	bridge: drop netfilter fake rtable unconditionally	2017-03-22 12:43:34 +01:00
br_netfilter_ipv6.c	netfilter: bridge: add and use br_nf_hook_thresh	2016-09-24 21:25:48 +02:00
br_netlink.c	bridge: netlink: check vlan_default_pvid range	2017-06-07 12:07:44 +02:00
br_nf_core.c	net: Remove protocol from struct dst_ops	2015-03-09 16:06:10 -04:00
br_private.h	net: bridge: change unicast boolean to exact pkt_type	2016-09-01 22:48:33 -07:00
br_private_stp.h	…
br_stp.c	net: bridge: br_set_ageing_time takes a clock_t	2016-07-25 10:30:03 -07:00
br_stp_bpdu.c	netfilter: Pass net into okfn	2015-09-17 17:18:37 -07:00
br_stp_if.c	net: bridge: start hello timer only if device is up	2017-06-14 15:05:52 +02:00
br_stp_timer.c	bridge: start hello_timer when enabling KERNEL_STP in br_stp_start	2017-06-07 12:07:44 +02:00
br_switchdev.c	bridge: switchdev: Add forward mark support for stacked devices	2016-08-26 13:13:36 -07:00
br_sysfs_br.c	net: bridge: set error code on failure	2016-12-05 13:26:22 -05:00
br_sysfs_if.c	net: bridge: add the multicast_flood flag attribute to brport_attrs	2016-10-13 12:16:36 -04:00
br_vlan.c	bridge: netlink: export per-vlan stats	2016-05-02 22:27:06 -04:00