Alexei Starovoitov 82303dd64a bpf: convert htab map to hlist_nulls ... commit 4fe8435909fddc97b81472026aa954e06dd192a5 upstream. when all map elements are pre-allocated one cpu can delete and reuse htab_elem while another cpu is still walking the hlist. In such case the lookup may miss the element. Convert hlist to hlist_nulls to avoid such scenario. When bucket lock is taken there is no need to take such precautions, so only convert map_lookup and map_get_next to nulls. The race window is extremely small and only reproducible with explicit udelay() inside lookup_nulls_elem_raw() Similar to hlist add hlist_nulls_for_each_entry_safe() and hlist_nulls_entry_safe() helpers. Fixes: 6c90598174 ("bpf: pre-allocate hash map elements") Reported-by: Jonathan Perry <jonperry@fb.com> Signed-off-by: Alexei Starovoitov <ast@kernel.org> Acked-by: Daniel Borkmann <daniel@iogearbox.net> Signed-off-by: David S. Miller <davem@davemloft.net> Signed-off-by: Chenbo Feng <fengc@google.com> Signed-off-by: Sasha Levin <sashal@kernel.org>		2019-05-16 19:43:40 +02:00
..
Makefile	…
arraymap.c	bpf: map_get_next_key to return first key on NULL	2018-05-09 09:50:19 +02:00
core.c	…
hashtab.c	bpf: convert htab map to hlist_nulls	2019-05-16 19:43:40 +02:00
helpers.c	…
inode.c	…
percpu_freelist.c	…
percpu_freelist.h	…
stackmap.c	bpf: fix wrong exposure of map_flags into fdinfo for lpm	2018-03-11 16:21:34 +01:00
syscall.c	bpf: map_get_next_key to return first key on NULL	2018-05-09 09:50:19 +02:00
verifier.c	bpf: check pending signals while verifying programs	2018-12-21 14:11:38 +01:00