Tejun Heo 55e3e1f419 workqueue: consider work function when searching for busy work items ... commit a2c1c57be8d9fd5b716113c8991d3d702eeacf77 upstream. To avoid executing the same work item concurrenlty, workqueue hashes currently busy workers according to their current work items and looks up the the table when it wants to execute a new work item. If there already is a worker which is executing the new work item, the new item is queued to the found worker so that it gets executed only after the current execution finishes. Unfortunately, a work item may be freed while being executed and thus recycled for different purposes. If it gets recycled for a different work item and queued while the previous execution is still in progress, workqueue may make the new work item wait for the old one although the two aren't really related in any way. In extreme cases, this false dependency may lead to deadlock although it's extremely unlikely given that there aren't too many self-freeing work item users and they usually don't wait for other work items. To alleviate the problem, record the current work function in each busy worker and match it together with the work item address in find_worker_executing_work(). While this isn't complete, it ensures that unrelated work items don't interact with each other and in the very unlikely case where a twisted wq user triggers it, it's always onto itself making the culprit easy to spot. Signed-off-by: Tejun Heo <tj@kernel.org> Reported-by: Andrey Isakov <andy51@gmx.ru> Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=51701 [lizf: Backported to 3.4: - Adjust context - Incorporate earlier logging cleanup in process_one_work() from 044c782ce3a9 ('workqueue: fix checkpatch issues')] Signed-off-by: Li Zefan <lizefan@huawei.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>		2013-08-29 09:50:12 -07:00
..
debug	kdb,vt_console: Fix missed data due to pager overruns	2012-10-21 09:27:59 -07:00
events	perf: Use css_tryget() to avoid propping up css refcount	2013-08-11 15:38:43 -07:00
gcov	…
irq	genirq: Fix can_request_irq() for IRQs without an action	2013-07-21 18:19:01 -07:00
power	ftrace: Disable function tracing during suspend/resume and hibernation, again	2012-08-09 08:31:29 -07:00
sched	sched: Fix the broken sched_rr_get_interval()	2013-08-11 15:38:43 -07:00
time	tick: Prevent uncontrolled switch to oneshot mode	2013-07-28 16:25:44 -07:00
trace	tracing: Fix fields of struct trace_iterator that are zeroed by mistake	2013-08-14 22:57:08 -07:00
.gitignore	…
Kconfig.freezer	…
Kconfig.hz	…
Kconfig.locks	locking/kconfig: Simplify INLINE_SPIN_UNLOCK usage	2012-03-23 13:18:57 +01:00
Kconfig.preempt	locking/kconfig: Simplify INLINE_SPIN_UNLOCK usage	2012-03-23 13:18:57 +01:00
Makefile	sysctl: Move the implementation into fs/proc/proc_sysctl.c	2012-01-24 16:37:54 -08:00
acct.c	Merge branch 'for-linus2' of git://git.kernel.org/pub/scm/linux/kernel/git/viro/vfs	2012-01-08 12:19:57 -08:00
async.c	Fix a dead loop in async_synchronize_full()	2012-10-02 10:30:35 -07:00
audit.c	constify path argument of audit_log_d_path()	2012-03-20 21:29:40 -04:00
audit.h	audit: remove AUDIT_SETUP_CONTEXT as it isn't used	2012-01-17 16:16:57 -05:00
audit_tree.c	kernel/audit_tree.c: tree will leak memory when failure occurs in audit_trim_trees()	2013-05-11 13:48:14 -07:00
audit_watch.c	…
auditfilter.c	audit: allow interfield comparison in audit rules	2012-01-17 16:17:01 -05:00
auditsc.c	kernel-doc: fix new warnings in auditsc.c	2012-01-23 08:44:53 -08:00
backtracetest.c	…
bounds.c	…
capability.c	Revert "capabitlies: ns_capable can use the cap helpers rather than lsm call"	2012-01-17 10:19:41 -08:00
cgroup.c	cgroup: fix an off-by-one bug which may trigger BUG_ON()	2013-05-07 19:51:56 -07:00
cgroup_freezer.c	cgroup: remove cgroup_subsys argument from callbacks	2012-02-02 09:20:22 -08:00
compat.c	compat: Fix RT signal mask corruption via sigprocmask	2012-05-10 08:58:33 -07:00
configs.c	…
cpu.c	CPU hotplug: provide a generic helper to disable/enable CPU hotplug	2013-06-20 11:58:44 -07:00
cpu_pm.c	…
cpuset.c	cpuset: fix cpuset_print_task_mems_allowed() vs rename() race	2013-03-04 06:06:44 +08:00
crash_dump.c	…
cred.c	cred: copy_process() should clear child->replacement_session_keyring	2012-04-11 08:20:11 -07:00
delayacct.c	…
dma.c	Remove all #inclusions of asm/system.h	2012-03-28 18:30:03 +01:00
elfcore.c	…
exec_domain.c	…
exit.c	posix_types.h: Cleanup stale __NFDBITS and related definitions	2012-08-09 08:31:39 -07:00
extable.c	…
fork.c	mm/fork: fix overflow in vma length when copying mmap on clone	2012-06-10 00:36:06 +09:00
freezer.c	PM / Freezer: Remove references to TIF_FREEZE in comments	2012-03-04 23:08:54 +01:00
futex.c	futex: Take hugepages into account when generating futex_key	2013-08-20 08:26:28 -07:00
futex_compat.c	futex: Revert "futex: Mark get_robust_list as deprecated"	2013-02-28 06:59:01 -08:00
groups.c	…
hrtimer.c	hrtimers: Move SMP function call to thread context	2013-07-28 16:26:47 -07:00
hung_task.c	hung_task: fix the broken rcu_lock_break() logic	2012-03-05 15:49:42 -08:00
irq_work.c	irq_work: fix compile failure on tile from missing include	2012-04-13 13:15:16 -04:00
itimer.c	itimer: Use printk_once instead of WARN_ONCE	2012-04-10 11:00:30 +02:00
jump_label.c	static keys: Inline the static_key_enabled() function	2012-02-28 20:01:08 +01:00
kallsyms.c	…
kexec.c	Merge branch 'akpm' (Andrew's patch-bomb)	2012-03-28 17:19:28 -07:00
kfifo.c	…
kmod.c	usermodehelper: check subprocess_info->path != NULL	2013-05-19 10:54:50 -07:00
kprobes.c	kprobes: return proper error code from register_kprobe()	2012-03-05 15:49:42 -08:00
ksysfs.c	…
kthread.c	kthread_worker: reimplement flush_kthread_work() to allow freeing the work item being executed	2012-10-02 10:30:40 -07:00
latencytop.c	…
lockdep.c	lockdep: Add CPU-idle/offline warning to lockdep-RCU splat	2012-02-21 09:06:06 -08:00
lockdep_internals.h	…
lockdep_proc.c	…
lockdep_states.h	…
module.c	module: fix out-by-one error in kallsyms	2012-11-26 11:37:41 -08:00
mutex-debug.c	…
mutex-debug.h	…
mutex.c	sched/rt: Use schedule_preempt_disabled()	2012-03-01 10:28:03 +01:00
mutex.h	…
notifier.c	…
nsproxy.c	…
padata.c	padata: Fix cpu hotplug	2012-03-29 19:52:46 +08:00
panic.c	panic: fix a possible deadlock in panic()	2013-04-12 09:38:47 -07:00
params.c	params: <level>_initcall-like kernel parameters	2012-03-26 12:50:51 +10:30
pid.c	vfs: fix panic in __d_lookup() with high dentry hashtable counts	2012-02-13 20:45:38 -05:00
pid_namespace.c	pidns: add reboot_pid_ns() to handle the reboot syscall	2012-03-28 17:14:36 -07:00
posix-cpu-timers.c	posix-cpu-timers: Fix nanosleep task_struct leak	2013-02-28 06:58:59 -08:00
posix-timers.c	posix-timer: Don't call idr_find() with out-of-range ID	2013-03-04 06:06:38 +08:00
printk.c	printk: fix buffer overflow when calling log_prefix function from call_console_drivers	2013-02-21 10:04:57 -08:00
profile.c	…
ptrace.c	ptrace: ensure arch_ptrace/ptrace_request can never race with SIGKILL	2013-01-27 20:47:43 -08:00
range.c	…
rcu.h	rcu: Allow nesting of rcu_idle_enter() and rcu_idle_exit()	2012-02-21 09:06:12 -08:00
rcupdate.c	rcu: Check for illegal use of RCU from offlined CPUs	2012-02-21 09:06:03 -08:00
rcutiny.c	rcu: Add RCU_NONIDLE() for idle-loop RCU read-side critical sections	2012-02-21 09:06:13 -08:00
rcutiny_plugin.h	rcu: Simplify unboosting checks	2012-02-21 09:03:43 -08:00
rcutorture.c	PTR_ERR should be called before its argument is cleared.	2012-02-21 09:06:10 -08:00
rcutree.c	rcu: Fix batch-limit size problem	2012-12-17 10:37:46 -08:00
rcutree.h	rcu: Rework detection of use of RCU by offline CPUs	2012-02-21 09:06:07 -08:00
rcutree_plugin.h	rcu: Hold off RCU_FAST_NO_HZ after timer posted	2012-02-21 09:42:30 -08:00
rcutree_trace.c	rcu: Rework detection of use of RCU by offline CPUs	2012-02-21 09:06:07 -08:00
relay.c	splice: fix racy pipe->buffers uses	2012-07-16 09:04:42 -07:00
res_counter.c	net: introduce res_counter_charge_nofail() for socket allocations	2012-01-22 15:08:46 -05:00
resource.c	kernel/resource.c: fix stack overflow in __reserve_region_with_split()	2013-02-14 10:48:53 -08:00
rtmutex-debug.c	lockdep, rtmutex, bug: Show taint flags on error	2011-12-06 08:16:49 +01:00
rtmutex-debug.h	…
rtmutex-tester.c	rtmutex-tester: convert sysdev_class to a regular subsystem	2011-12-14 14:54:22 -08:00
rtmutex.c	Revert "rcu: Permit rt_mutex_unlock() with irqs disabled"	2011-12-11 10:33:18 -08:00
rtmutex.h	…
rtmutex_common.h	…
rwsem.c	Remove all #inclusions of asm/system.h	2012-03-28 18:30:03 +01:00
seccomp.c	seccomp: audit abnormal end to a process due to seccomp	2012-01-17 16:16:55 -05:00
semaphore.c	…
signal.c	kernel/signal.c: stop info leak via the tkill and the tgkill syscalls	2013-04-25 21:19:54 -07:00
smp.c	smp: Fix SMP function call empty cpu mask race	2013-02-03 18:24:42 -06:00
softirq.c	Merge branch 'timers-core-for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip	2012-03-20 10:32:09 -07:00
spinlock.c	locking/kconfig: Simplify INLINE_SPIN_UNLOCK usage	2012-03-23 13:18:57 +01:00
srcu.c	rcu: Call out dangers of expedited RCU primitives	2012-02-21 09:06:08 -08:00
stacktrace.c	…
stop_machine.c	…
sys.c	reboot: rigrate shutdown/reboot to boot cpu	2013-06-20 11:58:45 -07:00
sys_ni.c	…
sysctl.c	sysctl: fix write access to dmesg_restrict/kptr_restrict	2012-04-05 14:51:43 +10:00
sysctl_binary.c	sysctl: fix null checking in bin_dn_node_address()	2013-03-04 06:06:41 +08:00
taskstats.c	…
test_kprobes.c	…
time.c	time: Remove bogus comments	2012-03-15 18:17:55 -07:00
timeconst.pl	timeconst.pl: Eliminate Perl warning	2013-02-28 06:58:58 -08:00
timer.c	timer: Fix jiffies wrap behavior of round_jiffies_common()	2013-07-21 18:19:01 -07:00
tracepoint.c	static keys: Introduce 'struct static_key', static_key_true()/false() and static_key_slow_[inc|dec]()	2012-02-24 10:05:59 +01:00
tsacct.c	[S390] cputime: add sparse checking and cleanup	2011-12-15 14:56:19 +01:00
uid16.c	…
up.c	…
user-return-notifier.c	…
user.c	…
user_namespace.c	…
utsname.c	…
utsname_sysctl.c	…
wait.c	lockdep/waitqueues: Add better annotation	2011-12-21 10:07:39 +01:00
watchdog.c	watchdog: using u64 in get_sample_period()	2012-12-03 11:47:17 -08:00
workqueue.c	workqueue: consider work function when searching for busy work items	2013-08-29 09:50:12 -07:00
workqueue_sched.h	…